i converted my NG grill to LP with correct orifices and drilled sizes per the BTU ratings. also changed regulator. Is there is difference in NG valves vs LP valves? This valve says its for LP grills, does it do both?

Changing out the orifices would just be a quick conversion and your grill will work well that way. A true conversion from natural gas to propane you would have to change the orifices as well as drilling out the valve core. The valve core is smaller for propane than it is for natural gas. Please note this does not apply to every single conversion. Please call for any additional information.